refactor(blogo,multi-renderer): change options polarity so zero-value is default value
This commit is contained in:
@@ -175,11 +175,10 @@ func (b *Blogo) render(src fs.File, w io.Writer) error {
|
||||
|
||||
log.Debug("Multiple renderers found, initializing built-in multi-renderer plugin")
|
||||
|
||||
f, t := false, true
|
||||
multi := NewMultiRenderer(MultiRendererOpts{
|
||||
SkipOnError: &f,
|
||||
PanicOnInit: &t,
|
||||
Logger: log,
|
||||
NotSkipOnError: false,
|
||||
NotPanicOnInit: true,
|
||||
Logger: log,
|
||||
})
|
||||
|
||||
for _, r := range b.renderers {
|
||||
|
||||
@@ -28,9 +28,9 @@ type multiRenderer struct {
|
||||
}
|
||||
|
||||
type MultiRendererOpts struct {
|
||||
SkipOnError *bool
|
||||
PanicOnInit *bool
|
||||
Logger *slog.Logger
|
||||
NotSkipOnError bool
|
||||
NotPanicOnInit bool
|
||||
Logger *slog.Logger
|
||||
}
|
||||
|
||||
func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
|
||||
@@ -39,16 +39,6 @@ func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
|
||||
opt = opts[0]
|
||||
}
|
||||
|
||||
if opt.SkipOnError == nil {
|
||||
d := true
|
||||
opt.SkipOnError = &d
|
||||
}
|
||||
|
||||
if opt.PanicOnInit == nil {
|
||||
d := true
|
||||
opt.PanicOnInit = &d
|
||||
}
|
||||
|
||||
if opt.Logger == nil {
|
||||
opt.Logger = slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{}))
|
||||
}
|
||||
@@ -57,8 +47,8 @@ func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
|
||||
return &multiRenderer{
|
||||
renderers: []RendererPlugin{},
|
||||
|
||||
skipOnError: *opt.SkipOnError,
|
||||
panicOnInit: *opt.PanicOnInit,
|
||||
skipOnError: !opt.NotSkipOnError,
|
||||
panicOnInit: !opt.NotPanicOnInit,
|
||||
|
||||
log: opt.Logger,
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user