refactor(blogo,multi-renderer): change options polarity so zero-value is default value

This commit is contained in:
Guz
2025-01-13 15:09:20 -03:00
parent 99e2af32f0
commit 1e94f1606f
2 changed files with 8 additions and 19 deletions

View File

@@ -175,11 +175,10 @@ func (b *Blogo) render(src fs.File, w io.Writer) error {
log.Debug("Multiple renderers found, initializing built-in multi-renderer plugin")
f, t := false, true
multi := NewMultiRenderer(MultiRendererOpts{
SkipOnError: &f,
PanicOnInit: &t,
Logger: log,
NotSkipOnError: false,
NotPanicOnInit: true,
Logger: log,
})
for _, r := range b.renderers {

View File

@@ -28,9 +28,9 @@ type multiRenderer struct {
}
type MultiRendererOpts struct {
SkipOnError *bool
PanicOnInit *bool
Logger *slog.Logger
NotSkipOnError bool
NotPanicOnInit bool
Logger *slog.Logger
}
func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
@@ -39,16 +39,6 @@ func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
opt = opts[0]
}
if opt.SkipOnError == nil {
d := true
opt.SkipOnError = &d
}
if opt.PanicOnInit == nil {
d := true
opt.PanicOnInit = &d
}
if opt.Logger == nil {
opt.Logger = slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{}))
}
@@ -57,8 +47,8 @@ func NewMultiRenderer(opts ...MultiRendererOpts) MultiRenderer {
return &multiRenderer{
renderers: []RendererPlugin{},
skipOnError: *opt.SkipOnError,
panicOnInit: *opt.PanicOnInit,
skipOnError: !opt.NotSkipOnError,
panicOnInit: !opt.NotPanicOnInit,
log: opt.Logger,
}