From 2ca40e1ef1f701505f05b70ab1b7e67a82a87a86 Mon Sep 17 00:00:00 2001
From: Guz013 <43732358+Guz013@users.noreply.github.com>
Date: Sat, 2 Sep 2023 20:33:13 -0300
Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20misc=20fixes?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixed problems config not being exported and used in the presets and
some rules not configured properly.
---
 configs/js/src/configs/index.js       | 2 ++
 configs/js/src/configs/problems.js    | 7 ++++---
 configs/js/src/configs/suggestions.js | 1 +
 configs/js/src/presets/recommended.js | 3 ++-
 configs/js/src/presets/strict.js      | 3 ++-
 5 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/configs/js/src/configs/index.js b/configs/js/src/configs/index.js
index 6254fe5..d9dc3a3 100644
--- a/configs/js/src/configs/index.js
+++ b/configs/js/src/configs/index.js
@@ -11,6 +11,7 @@ import documentation from './documentation.js';
 import suggestions from './suggestions.js';
 import formatting from './formatting.js';
 import overrides from './overrides.js';
+import problems from './problems.js';
 import naming from './naming.js';
 import core from './core.js';
 
@@ -21,6 +22,7 @@ const configs = {
 	formatting,
 	naming,
 	overrides,
+	problems,
 	suggestions,
 	'suggestions-typescript': typescript,
 };
diff --git a/configs/js/src/configs/problems.js b/configs/js/src/configs/problems.js
index 16fba5e..55f986b 100644
--- a/configs/js/src/configs/problems.js
+++ b/configs/js/src/configs/problems.js
@@ -44,9 +44,10 @@ const recommended = createVariations({
 		'no-irregular-whitespace': 'error',
 		'no-misleading-character-class': 'error',
 		'no-new-symbol': 'error',
+		'no-nonoctal-decimal-escape': 'error',
 		'no-obj-calls': 'error',
 		'no-octal': 'error',
-		'no-octal-decimal-escape': 'error',
+		'no-octal-escape': 'error',
 		'no-prototype-builtins': 'error',
 		'no-regex-spaces': 'error',
 		'no-self-assign': 'error',
@@ -61,7 +62,6 @@ const recommended = createVariations({
 		'no-unsafe-negation': 'error',
 		'no-unsafe-optional-chaining': 'error',
 		'no-unused-labels': 'error',
-		'no-unused-vars': 'error',
 		'no-useless-backreference': 'error',
 		'use-isnan': 'error',
 		'valid-typeof': 'error',
@@ -69,8 +69,10 @@ const recommended = createVariations({
 		...{}, // Plugin: @typescript-eslint/eslint-plugin
 		'@typescript-eslint/no-loss-of-precision': 'error',
 		'@typescript-eslint/no-redeclare': 'error',
+		'@typescript-eslint/no-unused-vars': 'error',
 		'no-loss-of-precision': 'off',
 		'no-redeclare': 'off',
+		'no-unused-vars': 'off',
 
 		...{}, // Plugin: eslint-plugin-import
 		'import/default': 'error',
@@ -95,7 +97,6 @@ const strict = createVariations({
 		'no-unmodified-loop-condition': 'error',
 		'no-unreachable-loop': 'error',
 		'no-unused-private-class-members': 'error',
-		'no-use-before-define': 'error',
 		'require-atomic-updates': 'error',
 
 		...{}, // Plugin: eslint-plugin-import
diff --git a/configs/js/src/configs/suggestions.js b/configs/js/src/configs/suggestions.js
index ad1fdb5..3cdef0f 100644
--- a/configs/js/src/configs/suggestions.js
+++ b/configs/js/src/configs/suggestions.js
@@ -318,6 +318,7 @@ const strict = createVariations({
 		'no-underscore-dangle': 'error',
 		'no-unneeded-ternary': 'error',
 		'no-unused-expressions': 'error',
+		'no-use-before-define': 'error',
 		'no-useless-call': 'error',
 		'no-useless-rename': 'error',
 		'no-useless-return': 'error',
diff --git a/configs/js/src/presets/recommended.js b/configs/js/src/presets/recommended.js
index 53d5ea9..78b561b 100644
--- a/configs/js/src/presets/recommended.js
+++ b/configs/js/src/presets/recommended.js
@@ -12,8 +12,9 @@ import configs from '../configs/index.js';
 /** @type {import('eslint').Linter.FlatConfig[]} */
 const recommended = [
 	configs.core,
-	configs['suggestions-typescript'].recommended.error,
+	configs.problems.recommended.error,
 	configs.suggestions.recommended.error,
+	configs['suggestions-typescript'].recommended.error,
 	configs.formatting.recommended.error,
 	configs.naming.recommended.error,
 	configs.documentation.recommended.error,
diff --git a/configs/js/src/presets/strict.js b/configs/js/src/presets/strict.js
index 303be11..1e752df 100644
--- a/configs/js/src/presets/strict.js
+++ b/configs/js/src/presets/strict.js
@@ -12,8 +12,9 @@ import configs from '../configs/index.js';
 /** @type {import('eslint').Linter.FlatConfig[]} */
 const strict = [
 	configs.core,
-	configs['suggestions-typescript'].strict.error,
+	configs.problems.strict.error,
 	configs.suggestions.strict.error,
+	configs['suggestions-typescript'].strict.error,
 	configs.formatting.strict.error,
 	configs.naming.strict.error,
 	configs.documentation.recommended.error,